Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reminder): Fix app version and requirement for files_reminder app #41676

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 23, 2023

By accident master and stable27 have the same app version and non-strict requirements on the server version.
For shipped apps the requirement must be 1-1 and the version must be bumped, so potential followup migrations can be executed on different branches

https://github.com/nextcloud/server/blob/master/apps/files_reminders/appinfo/info.xml#L11
https://github.com/nextcloud/server/blob/stable27/apps/files_reminders/appinfo/info.xml#L11

https://github.com/nextcloud/server/blob/master/apps/files_reminders/appinfo/info.xml#L21
https://github.com/nextcloud/server/blob/stable27/apps/files_reminders/appinfo/info.xml#L21

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Nov 23, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Nov 23, 2023
@nickvergessen nickvergessen self-assigned this Nov 23, 2023
@nickvergessen nickvergessen requested a review from Pytal as a code owner November 23, 2023 08:26
@nickvergessen nickvergessen merged commit f1a7fce into master Nov 23, 2023
40 of 41 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-reminder-version branch November 23, 2023 08:38
@blizzz blizzz mentioned this pull request Nov 23, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants