Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Use SVG as FilePicker buttons to bring back icons #41707

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix(files): Use SVG as FilePicker buttons to bring back icons #41707

merged 2 commits into from
Nov 24, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 23, 2023 •
edited
Loading

Summary

The FilePicker does not allow components as icons anymore so use SVG's instead.

Screenshots

before after
image image

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Nov 23, 2023
@susnux susnux force-pushed the fix/missing-icons-on-filepicker branch from 6bcc990 to 4d33fac Compare November 23, 2023 20:26
@susnux
Copy link
Contributor Author

susnux commented Nov 23, 2023

/backport to stable28

@susnux susnux self-assigned this Nov 23, 2023
@AndyScherzinger AndyScherzinger force-pushed the fix/missing-icons-on-filepicker branch from 4d33fac to faa2f2d Compare November 23, 2023 23:49
@susnux susnux disabled auto-merge November 24, 2023 00:47
@susnux
Copy link
Contributor Author

susnux commented Nov 24, 2023

Cypress unrelated, see #41712

@susnux susnux merged commit 9dd8382 into master Nov 24, 2023
40 of 42 checks passed
@susnux susnux deleted the fix/missing-icons-on-filepicker branch November 24, 2023 00:48
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 24, 2023
Merged
@SystemKeeper
Copy link
Contributor

"Neuer Ordner" does not have a icon as well - this is something different, right?

@susnux
Copy link
Contributor Author

susnux commented Nov 24, 2023

"Neuer Ordner" does not have a icon as well - this is something different, right?

Yes, that will be fixed with next dialog update.

@susnux susnux mentioned this pull request Nov 27, 2023
Closed
8 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge Awaiting requested review from artonge

@nfebe nfebe Awaiting requested review from nfebe

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews bug feature: files
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @SystemKeeper @AndyScherzinger @Pytal