-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(userstatus): add OOO automation and remove calendar automation #41714
Conversation
#41548 seems fixed 👍 |
My status changes to the short ooo message once the UserStatusAutomation job ran 👍 The status is reverted when I manually cancel my ooo 👍 |
Status changes to dnd when I am outside my working hours 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks sane
DND and OOO automations work as expected
/backport to stable28 |
bdb8c02
to
de4ad0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message field can be nullable from the frontend. Breaks with:
Message: Cannot assign null to property OCA\DAV\Db\Absence::$message of type string in file '/var/www/nextcloud/lib/public/AppFramework/Db/Entity.php' line 136
#40397 doesn't say anything about optional or required fields, but we need the short message for the status automation and the long one for Mail autoresponders. Let's make them both required. This can be tackled separately, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and wörks.
I also tested the "away" bug by following Christoph's steps and it seems to work correctly.
6a4d81e
to
6f9c22a
Compare
Signed-off-by: Anna Larch <[email protected]>
6f9c22a
to
f19645a
Compare
/backport to stable28 |
Summary
2nd try for the OOO automation.
The job handles the OOO automation now.
TODO
Checklist