Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dav): Allow single-day out of office #41816

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(dav): Allow single-day out of office #41816

merged 1 commit into from
Nov 29, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Nov 29, 2023 •
edited
Loading

Summary

Out of office can also be for one day only. The logic didn't allow that, now it does.

Todo

Checklist

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Nov 29, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Nov 29, 2023
@ChristophWurst ChristophWurst self-assigned this Nov 29, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable28

st3iny
st3iny approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

Needs #41703 to be checked out as well to work.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 29, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review November 29, 2023 13:10
@ChristophWurst ChristophWurst merged commit f8125cb into master Nov 29, 2023
49 of 50 checks passed
@ChristophWurst ChristophWurst deleted the fix/dav/single-day-ooo branch November 29, 2023 14:52
@ChristophWurst
Copy link
Member Author

/backport to stable28

1 similar comment
@ChristophWurst
Copy link
Member Author

/backport to stable28

@ChristophWurst ChristophWurst mentioned this pull request Dec 1, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny st3iny approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@GretaD GretaD Awaiting requested review from GretaD

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: dav
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to set out of office for a single day
3 participants
@ChristophWurst @st3iny @miaulalala