Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comments): Add a meta data column for comments #42209

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 13, 2023

Summary

Allows apps to store meta-data information into the comments table. A usecase that exists since a longer time is being able to indicate that a message was sent silently.
For the upcoming "Edit message" we want to store the actor and time information of the last person that edited a chat message, to avoid another database query on every chat request.

While changing the table anyway, I enforced the currently optional reference_id column which talk also relies on.

Checklist

@nickvergessen nickvergessen added enhancement 3. to review Waiting for reviews feature: comments pending documentation This pull request needs an associated documentation update labels Dec 13, 2023
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Dec 13, 2023
@nickvergessen nickvergessen self-assigned this Dec 13, 2023
@nickvergessen nickvergessen force-pushed the bugfix/noid/comments-meta-data branch from 2106989 to 09afaa2 Compare December 13, 2023 12:48
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm complains about the usage of updateQuery in the update method

lib/public/Comments/IComment.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/noid/comments-meta-data branch from be577c2 to b5a6376 Compare December 13, 2023 13:44
@nickvergessen nickvergessen force-pushed the bugfix/noid/comments-meta-data branch from d18634c to 226134a Compare December 14, 2023 13:32
@nickvergessen nickvergessen merged commit d6de7bf into master Dec 15, 2023
50 of 52 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/comments-meta-data branch December 15, 2023 05:56
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: comments pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants