Don't write back .htaccess file on a RO filesystem

[solracsf]

• Resolves: [Bug]: occ maintenance:install fails on read-only htdocs directory #42286

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

Shouldn’t we at least log something? Not being able to update the htaccess has consequences, no?

[solracsf]

We can, but here we're dealing with RO filesystems mainly, that are updated otherwise.

In RW filesystems, it will throw and log here (but also don't write or log in some cases, see line 571):

server/lib/private/Setup.php

Lines 562 to 573 in cd32db6

	if ($content !== '') {
	// Never write file back if disk space should be too low
	if (function_exists('disk_free_space')) {
	$df = disk_free_space(\OC::$SERVERROOT);
	$size = strlen($content) + 10240;
	if ($df !== false && $df < (float)$size) {
	throw new \Exception(\OC::$SERVERROOT . " does not have enough space for writing the htaccess file! Not writing it back!");
	}
	}
	//suppress errors in case we don't have permissions for it
	return (bool)@file_put_contents($setupHelper->pathToHtaccess(), $htaccessContent . $content . "\n");
	}

[Pilzinsel64]

Would be cool to get (backports of this) into the next minor updates for 28 and 27 if applicable, so we can push the latest security fixes to our users. :) nextcloud-snap/nextcloud-snap#2631 (comment)

[stondino00]

Any way we can patch this on 27.1.5 for the snap rather than waiting until the backport in 27.1.6? Thanks

[solracsf]

/backport to stable28

[solracsf]

/backport to stable27

[kyrofa]

Any way we can patch this on 27.1.5 for the snap rather than waiting until the backport in 27.1.6? Thanks

I don't believe we can do that without violating the integrity checks. We're going to have to wait for 27.1.6.