-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global accessibility switch #42353
Conversation
/backport to stable28 |
753a02a
to
5fe4a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks okay, but this mean, users cannot isolate weather to use new unified search from using the grid view...
Is this okay @AndyScherzinger
There are two switches:
|
In the current state, there is only one switch, the accessibility one. I thought the switch to toggle between unified and legacy search was only due to accessibility concern. Was I wrong? |
For Unified search, it could be a thing that there are accessibility issues, but the initial idea was to allow users who don't like new unified search to switch back, until we think it's stable enough. For example issues with unified search and filtering apps, or some user running into a problem with the new search then they can disable it. |
Yes this is okay, since we want to make things accessible anyway, where-ever possible. In case a system needs to be accessible by law, than like it is designed it is a yes/no question, hence a single config switch. |
That switch is also still there. So all good. |
5fe4a48
to
a6560f9
Compare
Signed-off-by: Louis Chemineau <[email protected]>
a6560f9
to
a39b3a3
Compare
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Adds new global config switch to disable non-accessible features:
enable_non-accessible_features
. (config.php)Fix #42222 #42262
PR for the image editor: nextcloud/viewer#2100