Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global accessibility switch #42353

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Dec 18, 2023

Adds new global config switch to disable non-accessible features: enable_non-accessible_features. (config.php)

Fix #42222 #42262

PR for the image editor: nextcloud/viewer#2100

@artonge artonge self-assigned this Dec 18, 2023
@artonge artonge added 3. to review Waiting for reviews accessibility labels Dec 18, 2023
@artonge artonge added this to the Nextcloud 29 milestone Dec 18, 2023
@artonge
Copy link
Contributor Author

artonge commented Dec 18, 2023

/backport to stable28

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay, but this mean, users cannot isolate weather to use new unified search from using the grid view...

Is this okay @AndyScherzinger

@susnux
Copy link
Contributor

susnux commented Dec 18, 2023

There are two switches:

  1. Enable new unified search or keep the legacy one
  2. Optionally Disable all not accessible features (new unified search, grid view, image editor). As soon as one of the features is accessible we can remove it from the list of not accessible features.

@artonge
Copy link
Contributor Author

artonge commented Dec 18, 2023

There are two switches:

In the current state, there is only one switch, the accessibility one.

I thought the switch to toggle between unified and legacy search was only due to accessibility concern. Was I wrong?

@nfebe
Copy link
Contributor

nfebe commented Dec 18, 2023

I thought the switch to toggle between unified and legacy search was only due to accessibility concern. Was I wrong?

For Unified search, it could be a thing that there are accessibility issues, but the initial idea was to allow users who don't like new unified search to switch back, until we think it's stable enough.

For example issues with unified search and filtering apps, or some user running into a problem with the new search then they can disable it.

@AndyScherzinger
Copy link
Member

Is this okay @AndyScherzinger

Yes this is okay, since we want to make things accessible anyway, where-ever possible. In case a system needs to be accessible by law, than like it is designed it is a yes/no question, hence a single config switch.

@AndyScherzinger
Copy link
Member

For Unified search, it could be a thing that there are accessibility issues, but the initial idea was to allow users who don't like new unified search to switch back, until we think it's stable enough.

That switch is also still there. So all good.

config/config.sample.php Outdated Show resolved Hide resolved
@artonge artonge force-pushed the artonge/feat/global_accessibility_switch branch from 5fe4a48 to a6560f9 Compare December 18, 2023 15:31
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/global_accessibility_switch branch from a6560f9 to a39b3a3 Compare December 19, 2023 09:23
@artonge artonge merged commit d8381ac into master Dec 19, 2023
51 checks passed
@artonge artonge deleted the artonge/feat/global_accessibility_switch branch December 19, 2023 10:32
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: create a server side switch for activation / deactivation a Grid View
6 participants