-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve path resolution in files_version hooks #42891
Merged
artonge
merged 1 commit into
master
from
artonge/fix/path_resolution_in_files_versions_hooks
Jan 18, 2024
Merged
Improve path resolution in files_version hooks #42891
artonge
merged 1 commit into
master
from
artonge/fix/path_resolution_in_files_versions_hooks
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
3. to review
Waiting for reviews
php
Pull requests that update Php code
labels
Jan 17, 2024
/backport to stable28 |
/backport to stable27 |
/backport to stable26 |
artonge
force-pushed
the
artonge/fix/path_resolution_in_files_versions_hooks
branch
from
January 17, 2024 16:17
8aca484
to
72abd8e
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/path_resolution_in_files_versions_hooks
branch
from
January 17, 2024 16:18
72abd8e
to
51fa2e3
Compare
8 tasks
skjnldsv
approved these changes
Jan 18, 2024
sorbaugh
approved these changes
Jan 18, 2024
artonge
deleted the
artonge/fix/path_resolution_in_files_versions_hooks
branch
January 18, 2024 10:08
This was referenced Jan 18, 2024
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user is logged in and is accessing the file through a public share, the fileinfo will be relative to the public share owner. So we need to resolve the path relative to the owner's root folder.
This PR ensure that we fall back to the owner root folder if the file cannot be found from the current user perspective.
Fix #40090