Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contacts): mouse now is pointer #42975

Conversation

emoral435
Copy link
Contributor

Summary

Contacts menu is now hoverable on all sections! The icon was not hoverable beforehand.

TODO

  • made icon hoverable

BEFORE AND AFTER

🏚️ Before 🏡 After
firefox_N5dzbiLu1o firefox_ywyd4fUx9v

Checklist

@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 20, 2024
@emoral435 emoral435 self-assigned this Jan 20, 2024
@emoral435 emoral435 marked this pull request as draft January 20, 2024 00:31
@emoral435
Copy link
Contributor Author

Will make this an official PR once this question gets answered, as I may have to add more!

@emoral435
Copy link
Contributor Author

/skjnldsv-backport bacaa30 to stable28

@susnux
Copy link
Contributor

susnux commented Jan 20, 2024

I am not sure that this is not a problem in NcHeaderMenu. Especially as there are other issues like the trigger has not the correct color applied.

@skjnldsv
Copy link
Member

I think this should be in the vue components :)

@emoral435
Copy link
Contributor Author

True, this solution is more of a fast-acting bandaid - rather than a preventative cause. I'll instead just make a PR to NcVue, to the actual component :)

@emoral435
Copy link
Contributor Author

Closing

@emoral435 emoral435 closed this Jan 20, 2024
@Pytal Pytal deleted the fix/a11y/42959/no-mouse-pointer-at-search-and-notifications-icons branch January 22, 2024 20:01
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: No mouse pointer at search and notification icons
3 participants