Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weather_status): Fix location format for OpenAPI #42996

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

provokateurin
Copy link
Member

Summary

Previously lat and lon were typed as float but they are always string. I fixed that and also fixed the type hierarchy so now all the endpoints use the same base type for locations.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Jan 21, 2024
@provokateurin provokateurin added this to the Nextcloud 29 milestone Jan 21, 2024
@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, but looking good

@blizzz blizzz mentioned this pull request Jan 22, 2024
@blizzz blizzz merged commit 90a551d into master Jan 22, 2024
53 checks passed
@blizzz blizzz deleted the fix/weather_status/location-format branch January 22, 2024 09:00
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants