Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync with new OCP\IAppConfig #43132

Merged
merged 5 commits into from
Feb 1, 2024
Merged

sync with new OCP\IAppConfig #43132

merged 5 commits into from
Feb 1, 2024

Conversation

ArtificialOwl
Copy link
Member

Requested enhancement: #41755 (comment)

@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Jan 25, 2024
@ArtificialOwl ArtificialOwl added this to the Nextcloud 29 milestone Jan 25, 2024
@ArtificialOwl ArtificialOwl force-pushed the enh/41755/update-appframework-api branch from c52ee78 to b5273d2 Compare January 25, 2024 23:06
nickvergessen
nickvergessen reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the right time to add unit tests :-X

nickvergessen
nickvergessen reviewed Jan 30, 2024
View reviewed changes
lib/private/AppFramework/Services/AppConfig.php Outdated Show resolved Hide resolved
lib/private/AppFramework/Services/AppConfig.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Services/IAppConfig.php Outdated Show resolved Hide resolved
lib/public/AppFramework/Services/IAppConfig.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen mentioned this pull request Jan 31, 2024
Merged
6 tasks
@ArtificialOwl ArtificialOwl force-pushed the enh/41755/update-appframework-api branch from 20dee78 to c9162d3 Compare January 31, 2024 17:57
@ArtificialOwl
sync with new OCP\IAppConfig
86835ee 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl
fix psalm
51fa22d 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl
adding test
e1d7328 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl
fix lint
1956be4 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl force-pushed the enh/41755/update-appframework-api branch from 65104fc to 1956be4 Compare January 31, 2024 22:13
nickvergessen
nickvergessen reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry for the confusion, as per chat the tests cover "core Appconfig" and should therefore be moved there, the Service is not really usefully testable)

tests/lib/AppFramework/Services/AppConfigTest.php Outdated Show resolved Hide resolved
tests/lib/AppFramework/Services/AppConfigTest.php Outdated Show resolved Hide resolved
@ArtificialOwl
better tests
31c1bc1 
Signed-off-by: Maxence Lange <[email protected]>
@ArtificialOwl ArtificialOwl merged commit b838237 into master Feb 1, 2024
134 checks passed
@ArtificialOwl ArtificialOwl deleted the enh/41755/update-appframework-api branch February 1, 2024 20:51
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 22, 2024
@ChristophWurst
Copy link
Member

new APIs mandate developer docs

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@ArtificialOwl @ChristophWurst @nickvergessen @juliusknorr