Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Update webdav to make XML entities in filenames work #43353

Merged
merged 2 commits into from
Feb 9, 2024
Merged

fix(files): Update webdav to make XML entities in filenames work #43353

merged 2 commits into from
Feb 9, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 5, 2024 •
edited
Loading

Summary

Update webdav and add regression tests for getting filenames with XML entities in their name to work.

Checklist

@susnux susnux force-pushed the fix/webdav-client-double-decode branch 2 times, most recently from 4b1fb57 to 53c8b7e Compare February 5, 2024 14:52
@susnux susnux requested review from skjnldsv, a team, nfebe and szaimen and removed request for a team February 5, 2024 14:54
@susnux susnux added this to the Nextcloud 29 milestone Feb 5, 2024
@susnux susnux changed the title Fix/webdav client double decode fix(files): Update webdav to make XML entities in filenames work Feb 5, 2024
@susnux
Copy link
Contributor Author

susnux commented Feb 5, 2024

/backport to stable28

@susnux susnux marked this pull request as ready for review February 5, 2024 14:55
@susnux susnux force-pushed the fix/webdav-client-double-decode branch from 53c8b7e to 1dae413 Compare February 5, 2024 16:01
szaimen
szaimen approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux force-pushed the fix/webdav-client-double-decode branch from 1dae413 to 4f29df7 Compare February 9, 2024 01:26
@susnux susnux enabled auto-merge February 9, 2024 01:27
susnux added 2 commits February 9, 2024 11:08
@susnux
fix(files): Update webdav to 5.3.2 fixing handling of files with XM…
fbba6f9 
…L entities in their names

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
chore: Compile assets
5be93eb 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/webdav-client-double-decode branch from 4f29df7 to 5be93eb Compare February 9, 2024 10:08
@susnux susnux merged commit 677e386 into master Feb 9, 2024
85 checks passed
@susnux susnux deleted the fix/webdav-client-double-decode branch February 9, 2024 10:48
@backportbot backportbot bot mentioned this pull request Feb 9, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot operate on any files with HTML entities in their name
3 participants
@susnux @skjnldsv @szaimen