-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement team provider api #43855
Implement team provider api #43855
Conversation
d454c55
to
f4c3882
Compare
75c86ef
to
276cff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some detail findings (that partly I would have expected to be found by CI). In general, everything is layed out fine 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI LGTM
9b181e5
to
82b08ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI is good
7123a1c
to
3ca15ba
Compare
Signed-off-by: Julius Härtl <[email protected]>
3ca15ba
to
c7813bf
Compare
Cypress failure is unrelated |
Does this mean we need to add the Circles app to |
One way to solve it, I'd rather say we need a |
Resolves #43683
Teams are considered evolution of circles where we now want to aggregate all resources that are related (shared or owned) by a given team. Therefore we need a generic API so that apps that offer sharing to teams can expose the list of resources and teams for a given resource.
Example implementation can be found for deck and collectives already.
In the future we may extend this namespace to become a stable OCP/OCS API for other methods related to circles which for now is still bound to the classes in
OCA\Circles
.ToDo
Provider implementations