Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Open new file when created from template #43941

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 1, 2024

Summary

Fix a small bug from #42993 where the, not implemented, node:focus event was used instead of changing the route.

Screencast

vokoscreenNG-2024-03-01_18-27-09.mp4

Checklist

@susnux susnux requested review from Pytal and a team March 1, 2024 17:30
@susnux susnux self-assigned this Mar 1, 2024
@susnux susnux requested a review from skjnldsv as a code owner March 1, 2024 17:30
@susnux susnux requested review from nfebe and sorbaugh and removed request for a team March 1, 2024 17:30
@susnux
Copy link
Contributor Author

susnux commented Mar 1, 2024

/backport to stable28

@susnux susnux force-pushed the fix/files-open-text branch from f669f57 to b8272cc Compare March 4, 2024 23:55
@skjnldsv skjnldsv merged commit e072035 into master Mar 5, 2024
96 of 98 checks passed
@skjnldsv skjnldsv deleted the fix/files-open-text branch March 5, 2024 17:21
Copy link

backportbot bot commented Mar 5, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/43941/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b8272ccc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43941/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Mar 5, 2024

/backport to stable28

Copy link

backportbot bot commented Mar 5, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/43941/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b8272ccc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43941/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Issues with newly created files (set name and open automatically)
3 participants