Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SetupChecks): Add hint about dns/firewall if mjs check can't run #44621

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

joshtrichards
Copy link
Member

Summary

Helps cut down on troubleshooting time with:

TODO

  • ...

Checklist

@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards joshtrichards requested a review from szaimen April 2, 2024 14:33
@joshtrichards joshtrichards force-pushed the enh/mjs-dns-fw-failing-check-run-hint branch 2 times, most recently from 633e55d to 5ada311 Compare April 2, 2024 15:06
@joshtrichards joshtrichards changed the title enh(SetupChecks): Add hint re: dns/firewall if mjs check can't run enh(SetupChecks): Add hint about dns/firewall if mjs check can't run Apr 2, 2024
@susnux
Copy link
Contributor

susnux commented Apr 2, 2024

@joshtrichards can you change the commit to fix(...) which reflects the changes better and complies with conventional commits.

@joshtrichards joshtrichards force-pushed the enh/mjs-dns-fw-failing-check-run-hint branch from 5ada311 to e89ebbf Compare April 2, 2024 15:13
@joshtrichards joshtrichards changed the title enh(SetupChecks): Add hint about dns/firewall if mjs check can't run fix(SetupChecks): Add hint about dns/firewall if mjs check can't run Apr 2, 2024
@joshtrichards
Copy link
Member Author

Done. Other test failures don't so far appear to be related.

@susnux susnux force-pushed the enh/mjs-dns-fw-failing-check-run-hint branch from e89ebbf to 66fad4a Compare April 2, 2024 16:10
@susnux susnux merged commit 6bced38 into master Apr 2, 2024
167 checks passed
@susnux susnux deleted the enh/mjs-dns-fw-failing-check-run-hint branch April 2, 2024 16:50
Copy link

backportbot bot commented Apr 2, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44621/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 66fad4ae

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44621/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor

susnux commented Apr 2, 2024

/backport to stable28

Copy link

backportbot bot commented Apr 2, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44621/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 66fad4ae

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44621/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants