-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): also trigger new tab on file name middle click #45571
Conversation
/backport to stable29 |
/backport to stable28 |
This comment was marked as resolved.
This comment was marked as resolved.
Ah, no! Now I do remember! If we want to remove the default click-to-download behaviour is a different topic in itself @ShGKme :) |
Alright, I tested on safari and it works!
So leaving them both is the way 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested in a Chromium based browser on Windows and seems to work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Safari 16 and Safari 17, both testing cloud and real MacBook.
Although MDN and caniuse say this event is not supported on Safari completely, it works fine on both list and grid with the middle button click.
But @click.middle
would avoid the need to check event.button
👀
/compile rebase-amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
ffd0c9d
to
a094ac0
Compare
I think this also make the right-click trigger the default action |
Fix #44994