Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): also trigger new tab on file name middle click #45571

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

skjnldsv
Copy link
Member

Fix #44994

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: files papercut Annoying recurring issue with possibly simple fix. labels May 29, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone May 29, 2024
@skjnldsv skjnldsv requested review from ShGKme and a team May 29, 2024 17:16
@skjnldsv skjnldsv self-assigned this May 29, 2024
@skjnldsv skjnldsv requested review from Pytal, szaimen and sorbaugh and removed request for a team May 29, 2024 17:16
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

ShGKme

This comment was marked as outdated.

@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

Ah, no! Now I do remember!
We do indeed have different links, that was how it was before.
We can discuss the default link expectations like Julius said, but as a fix, I think we should still merge this PR (after the auxclick adjusting).

If we want to remove the default click-to-download behaviour is a different topic in itself @ShGKme :)

@skjnldsv
Copy link
Member Author

skjnldsv commented May 30, 2024

Alright, I tested on safari and it works!

  • if I remove the auxclick it fails on chrome
  • the click seems to only work on safari

So leaving them both is the way 👍
Please review again @ShGKme, and let's open a ticket afterwards to discuss the default link for 30 and above 👍

@skjnldsv skjnldsv requested a review from ShGKme May 30, 2024 07:16
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested in a Chromium based browser on Windows and seems to work :)

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Safari 16 and Safari 17, both testing cloud and real MacBook.

Although MDN and caniuse say this event is not supported on Safari completely, it works fine on both list and grid with the middle button click.

But @click.middle would avoid the need to check event.button 👀

@skjnldsv
Copy link
Member Author

/compile rebase-amend /

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv merged commit 6ec6c1f into master Jun 12, 2024
109 checks passed
@skjnldsv skjnldsv deleted the fix/files-middle-click branch June 12, 2024 14:31
@artonge
Copy link
Contributor

artonge commented Jun 13, 2024

I think this also make the right-click trigger the default action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: files papercut Annoying recurring issue with possibly simple fix. regression
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Files app doesn't open middle-clicked file/folder in new browser tab since Nextcloud 28
4 participants