feat(db): switch from settype to casts #48010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
enhancement
2. developing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
miaulalala
requested review from
come-nc,
tcitworld,
icewind1991 and
skjnldsv
miaulalala
added
3. to review
miaulalala
force-pushed
the
feat/switch-from-settype-to-casts
branch
from
3526363
to
10a1758
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
feat/switch-from-settype-to-casts
branch
from
10a1758
to
6c36c54
Compare
AndyScherzinger
approved these changes
Sep 15, 2024
|
@miaulalala do you have a rough number how much faster the overall API call on a service-layer-level will then be with this improvement? |
|
I don't know - i can do some comparisons against stable30 and master with blackfire? |
|
Only if it is not too much work. Was just thinking about it, in case it would be worth mentioning with v31, than marketing would need some numbers / comparison. |
|
Just claim the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anna Larch [email protected]
Summary
casting directly to the proper type is up to 6 times faster than using
settypeAlso added the types for the methods, let's see if things go boom (although they might not without strict types)
TODO
Checklist