Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 16, 2024

Fix #41037

Summary

This contains multiple "things":

  • ❇️ Allow GET on folders to download them
    • if no accept header for ZIP is sent then (for browser download) allow GET params but if nothing set then fallback to Sabre -> should be non-breaking
  • 🐛 This now also allows downloading "select-multiple" files form e.g. "recent" or "favorites" view where the files are not really located in the same folder.

Checklist

@susnux susnux added the 3. to review Waiting for reviews label Sep 16, 2024
@susnux susnux requested a review from come-nc September 16, 2024 14:44
@susnux susnux added this to the Nextcloud 31 milestone Sep 16, 2024
@susnux susnux marked this pull request as ready for review September 16, 2024 15:35
@susnux susnux requested a review from skjnldsv as a code owner September 16, 2024 15:35
@susnux susnux force-pushed the feat/zip-folder-plugin branch from 8b6c19d to 2e3dd35 Compare September 16, 2024 15:56
@susnux susnux force-pushed the feat/zip-folder-plugin branch 2 times, most recently from 197f151 to 6c97ecf Compare September 16, 2024 23:56
@come-nc come-nc force-pushed the feat/zip-folder-plugin branch from 6532ccb to 37741d5 Compare September 20, 2024 15:31
@susnux susnux force-pushed the feat/zip-folder-plugin branch 4 times, most recently from 62a1afa to 7a29e55 Compare September 26, 2024 23:28
…V `ZipFolderPlugin`

Signed-off-by: Ferdinand Thiessen <[email protected]>
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honor Accept header when downloading directories
3 participants