Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reduce count for subadmins if they are members of group #48532

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 2, 2024

Summary

Counter on sidebar doesn't reflect the actual number of group members, if subadmin is a member too.
For each group, counter is reduced by 1, and for 'All accounts', counter is reduced by amount of groups subadmin is in.

There is a comment:

we prevent subadmins from looking up themselves so we lower the count of the groups he belongs to

but I don't see a point of it, since we fetch and show yourself in the list anyway, so just removing inconsistency

Before After
image image
Subadmin: 'alice', member of 'test group' and 'test group 2'

TODO

  • ...

Checklist

@Antreesy Antreesy added this to the Nextcloud 31 milestone Oct 2, 2024
@Antreesy Antreesy self-assigned this Oct 2, 2024
@Antreesy Antreesy force-pushed the fix/48437/dont-exclude-user branch from f460c33 to 583f015 Compare October 2, 2024 13:55
@provokateurin
Copy link
Member

/backport to stable30

@provokateurin
Copy link
Member

/backport to stable29

@provokateurin
Copy link
Member

/backport to stable28

@Antreesy Antreesy force-pushed the fix/48437/dont-exclude-user branch from 583f015 to 0d6acbf Compare October 2, 2024 16:33
@Antreesy Antreesy requested a review from provokateurin October 2, 2024 16:33
@blizzz blizzz merged commit 67e0928 into master Oct 4, 2024
175 checks passed
@blizzz blizzz deleted the fix/48437/dont-exclude-user branch October 4, 2024 18:03

This comment was marked as outdated.

@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 4, 2024

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants