fix(streamer): zip64 should work on 32-bit now #49035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should work again now that DeepDiver1975/PHPZipStreamer#11 is merged. We've already bumped v28-v30 up to >2.0.1 of ZipStreamer (in nextcloud/3rdparty#1673 and nextcloud/3rdparty#1863).
Untested since I no longer have a 32-bit environment set up for testing.
Came up while looking into nextcloud/files_zip#200.
Maybe @bcutter feels like testing this change too for the standard built-in zip mechanism? :)
To test:
TODO
Checklist