Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] feat: Add X-NC-Disable-Scheduling property to allow skipping scheduling #49253

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 13, 2024

Backport of PR #49139


// do not send imip messages if external system already did
/** @psalm-suppress UndefinedPropertyFetch */
if ($iTipMessage->message?->VEVENT?->{'X-NC-DISABLE-SCHEDULING'}?->getValue() === 'true') {

Check notice

Code scanning / Psalm

DocblockTypeContradiction Note

Sabre\VObject\Component\VCalendar does not contain null

// do not send imip messages if external system already did
/** @psalm-suppress UndefinedPropertyFetch */
if ($iTipMessage->message?->VEVENT?->{'X-NC-DISABLE-SCHEDULING'}?->getValue() === 'true') {

Check notice

Code scanning / Psalm

RedundantConditionGivenDocblockType Note

Docblock-defined type Sabre\VObject\Component\VCalendar for $__tmp_nullsafe__4649 is never null
@SebastianKrupinski SebastianKrupinski merged commit 1a411ff into stable28 Nov 13, 2024
56 checks passed
@SebastianKrupinski SebastianKrupinski deleted the backport/49139/stable28 branch November 13, 2024 21:30
@skjnldsv skjnldsv mentioned this pull request Nov 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants