feat(systemtags): add color support #49295
Draft
+631
−429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
enhancement
design
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
887004b
to
d7df8e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
feat/systemtags-bulk-create-list
branch
from
51a2dff
to
99a7346
Compare
skjnldsv
force-pushed
the
feat/tags-colors
branch
4 times, most recently
from
a0248a7
to
6bf50f7
Compare
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
6bf50f7
to
c6afe55
Compare
jancborchardt
approved these changes
Nov 20, 2024
jancborchardt
requested changes
Nov 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@jancborchardt There is also the inline tag display missing on this PR. I'll keep them like they are right now, no background and color the text+border only, following the WCAG contrast of course. Quick example (careful, contrast hasn't been calculated, this is just a mockup) |
skjnldsv
force-pushed
the
feat/tags-colors
branch
2 times, most recently
from
98ff185
to
2df84f9
Compare
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/tags-colors
branch
from
2df84f9
to
8b6216f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6778
WIP
In progress
Screenshot