Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add first login timestamp of each user to oc_preferences and user:info output #49377

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: Add first login timestamp of each user to oc_preferences and user:info output #49377

wants to merge 11 commits into from
+584 −174

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 19, 2024 •
edited by Pytal
Loading

See #22640
Close #48649

Summary

Add First login information in the user settings, as is done for last login

  • Add it to the UI
  • Decide how to handle migration

Checklist

@come-nc come-nc self-assigned this Nov 19, 2024
@come-nc come-nc added the 2. developing Work in progress label Nov 19, 2024
@come-nc come-nc added this to the Nextcloud 31 milestone Nov 19, 2024
@come-nc come-nc force-pushed the enh/add-first-login-timestamp branch from eb486cc to fd366a6 Compare November 21, 2024 15:06
@come-nc
Copy link
Contributor Author

come-nc commented Nov 21, 2024

  • Decide how to handle migration

I now store -1 for users which have already logged in before upgrade to 31, and show that as "unknown" in user:info output.

@come-nc come-nc force-pushed the enh/add-first-login-timestamp branch from fd366a6 to f8c42b7 Compare December 3, 2024 09:20
@Pytal
Copy link
Member

Pytal commented Dec 5, 2024

✅ Add it to the UI
image

Pytal
Pytal reviewed Dec 5, 2024
View reviewed changes
core/Command/User/Info.php Outdated
@@ -56,7 +72,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
'groups' => $groups,
'quota' => $user->getQuota(),
'storage' => $this->getStorageInfo($user),
'last_seen' => date(\DateTimeInterface::ATOM, $user->getLastLogin()), // ISO-8601
'first_seen' => $firstSeen,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked user:info first_seen and looks good 👍

Can we also show this in user:list --info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

But I’m remembering now that last time a PR tried to show never for last_seen @nickvergessen objected that this was a breaking change.
So not sure what is the best way ahead here. It is not appropriate to show fake timestamp for never/unknown, on the other hand scripts need to be aware of it.
Maybe we simply note this as a breaking change and still merge the change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Tested, thanks 🙏

@Pytal Pytal self-assigned this Dec 5, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Dec 9, 2024

/compile /

@come-nc
Copy link
Contributor Author

come-nc commented Dec 9, 2024

✅ Add it to the UI image

Can you change the order to have first login before last login? Both in columns and settings. It’s disturbing to have last first.

@Pytal Pytal force-pushed the enh/add-first-login-timestamp branch from 159276f to f102154 Compare December 9, 2024 22:30
@come-nc come-nc force-pushed the enh/add-first-login-timestamp branch from f00a83d to 99ba7d3 Compare December 10, 2024 09:19
come-nc and others added 11 commits December 10, 2024 09:49
@come-nc @Pytal
feat: Add first login timestamp of each user to oc_preferences and us…
6267db2 
…er:info output

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
chore: Update openapi specs
3503b1f 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
fix(tests): Adapt tests to firstLogin new feature
4daf66f 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
feat(users): Use -1 for unknown firstLogin instead of setting it to c…
a254d99 
…urrent date

Signed-off-by: Côme Chilliet <[email protected]>
@Pytal
feat: Show first login date in user list
795c927 
Signed-off-by: Christopher Ng <[email protected]>
@come-nc @Pytal
feat(occ): Show first_seen in output of user:list --info
3d7def3 
Also format unknown and never in a better way.

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @nickvergessen @Pytal
fix: Return timestamps in unix format rather than milliseconds
089d0b3 
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
fix(users): Adapt UI code to new timestamp fields names
e423d2a 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
chore: Update openapi.json files
2b84c56 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc @Pytal
fix(tests): Fix getLastLogin expectation in UsersControllerTest
2d1d4b3 
Signed-off-by: Côme Chilliet <[email protected]>
@Pytal
chore: compile assets
8f05db4 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the enh/add-first-login-timestamp branch from 6a68788 to 8f05db4 Compare December 10, 2024 18:03
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 10, 2024
@Pytal Pytal requested review from a team, icewind1991 and artonge and removed request for a team December 10, 2024 18:08
@Pytal Pytal enabled auto-merge December 10, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Pytal Pytal Pytal approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@Pytal Pytal

@come-nc come-nc

Labels
3. to review Waiting for reviews enhancement feature: occ feature: users and groups
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Show "First Login" and "Creation Date" it on the account Management Table as new columns
4 participants
@come-nc @Pytal @nickvergessen @provokateurin