Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] feat: Use inline password confirmation in external storage settings #49547

Merged
merged 7 commits into from
Nov 28, 2024
Merged

[stable30] feat: Use inline password confirmation in external storage settings #49547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5afae27
chore: Bump @nextcloud/password-confirmation to 5.3.0
artonge Nov 28, 2024
97732de
feat: Use inline password confirmation in external storage settings
artonge Nov 27, 2024
38add08
chore: Run npm run lint:fix
artonge Nov 27, 2024
69f6ba2
chore: Compile assets
artonge Nov 26, 2024
d224b3f
test:(PasswordConfirmationMiddleware): Fix constructor call
artonge Nov 27, 2024
d3274bc
test(ExternalStorage): Send basic auth during integrations tests
artonge Nov 28, 2024
b16336a
chore: Compile assets
artonge Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,551 changes: 0 additions & 1,551 deletions apps/files_external/js/settings.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion apps/files_external/lib/Controller/AjaxController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public function getSshKeys($keyLength = 1024) {
* @return bool
*/
#[NoAdminRequired]
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function saveGlobalCredentials($uid, $user, $password) {
$currentUser = $this->userSession->getUser();
if ($currentUser === null) {
Expand Down
4 changes: 2 additions & 2 deletions apps/files_external/lib/Controller/GlobalStoragesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function __construct(
*
* @return DataResponse
*/
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function create(
$mountPoint,
$backend,
Expand Down Expand Up @@ -136,7 +136,7 @@ public function create(
*
* @return DataResponse
*/
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function update(
$id,
$mountPoint,
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/lib/Controller/StoragesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public function show(int $id, $testOnly = true) {
*
* @return DataResponse
*/
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function destroy(int $id) {
try {
$this->service->removeStorage($id);
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/lib/Controller/UserGlobalStoragesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public function show($id, $testOnly = true) {
* @return DataResponse
*/
#[NoAdminRequired]
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function update(
$id,
$backendOptions,
Expand Down
6 changes: 3 additions & 3 deletions apps/files_external/lib/Controller/UserStoragesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public function show(int $id, $testOnly = true) {
* @return DataResponse
*/
#[NoAdminRequired]
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function create(
$mountPoint,
$backend,
Expand Down Expand Up @@ -156,7 +156,7 @@ public function create(
* @return DataResponse
*/
#[NoAdminRequired]
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function update(
$id,
$mountPoint,
Expand Down Expand Up @@ -208,7 +208,7 @@ public function update(
* {@inheritdoc}
*/
#[NoAdminRequired]
#[PasswordConfirmationRequired]
#[PasswordConfirmationRequired(strict: true)]
public function destroy(int $id) {
return parent::destroy($id);
}
Expand Down
Loading
Loading