Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't propagate future mtimes #49551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't propagate future mtimes #49551

wants to merge 1 commit into from
+9 −2

Conversation

icewind1991
Copy link
Member

When uploading a file with an mtime in the future the parent folders also get the future timestamp.

This clamps the propagated mtime to the current one to prevent this.

to test:

  • create a local file with a timestamp in the future: touch -d "now +1 year" test.txt
  • Create a folder test
  • Upload test.txt into the test folder
  • Check the mtime of the test folder

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 28, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Nov 28, 2024
@icewind1991 icewind1991 requested review from provokateurin, a team, ArtificialOwl and Altahrim and removed request for a team November 28, 2024 15:55
@icewind1991
Copy link
Member Author

reverted the constructor argument changes, was causing to much splash damage

@icewind1991
Copy link
Member Author

/backport to stable30

@icewind1991
Copy link
Member Author

/backport to stable29

@Altahrim
Copy link
Collaborator

reverted the constructor argument changes, was causing to much splash damage

I didn't saw the "splash", do you think we could backport this and add clock in constructor for master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @Altahrim @provokateurin