Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setupcheck): Make the Memcache setupcheck use the cache #49588

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nickvergessen
Copy link
Member

Summary

I made a typo in the host url of the redis, but the setupcheck worked and only later on once someone that used external storage accessed the instance, it failed and errored.

Steps:

  1. Install php redis
  2. Setup the following Nextcloud config
  'memcache.local' => '\\OC\\Memcache\\Redis',
  'memcache.distributed' => '\\OC\\Memcache\\Redis',
  'memcache.locking' => '\\OC\\Memcache\\Redis',
  'redis' => 
  array (
    'host' => '127.0.213.1',
    'port' => 6379,
  ),
Before After
grafik Bildschirmfoto vom 2024-12-02 09-01-40

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Dec 2, 2024
@nickvergessen nickvergessen requested review from come-nc and a team December 2, 2024 08:08
@nickvergessen nickvergessen self-assigned this Dec 2, 2024
@nickvergessen nickvergessen requested review from ArtificialOwl and Altahrim and removed request for a team December 2, 2024 08:08
@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen nickvergessen force-pushed the bugfix/noid/make-the-cache-check-use-it branch from 857f133 to ce1eb32 Compare December 2, 2024 08:11
@nickvergessen nickvergessen force-pushed the bugfix/noid/make-the-cache-check-use-it branch from ce1eb32 to 1bcc381 Compare December 2, 2024 08:18
@nickvergessen nickvergessen merged commit 199515f into master Dec 2, 2024
186 of 188 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/make-the-cache-check-use-it branch December 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants