fix(dav): Create SAB at installation #51144
Open
+85
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
hamza221 and
SebastianKrupinski
as code owners
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
SebastianKrupinski
approved these changes
Feb 28, 2025
Signed-off-by: Christoph Wurst <[email protected]>
kesselb
reviewed
Mar 1, 2025
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors |
There was a problem hiding this comment.
Suggested change
| * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | |
| * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors |
| protected function setUp(): void { | ||
| parent::setUp(); | ||
|
|
||
| $this->syncService = $this->createMock(SyncService::class); |
There was a problem hiding this comment.
Please add a class member for syncService and step to avoid the deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The SAB is created on demand. Weirdly enough this only happens for the second user of an instance, and in high concurrent setups there can be a race for the creation of the AB.
This moves the creation to an install repair step that is run once at installation time.
This change was tested with nextcloud/mail#10707. Recently Mail integration tests failed when the SAB didn't exist and tests created it while being in a transaction.
TODO
Checklist