Skip to content

Commit

Permalink
Setting for selecting recording browser
Browse files Browse the repository at this point in the history
Signed-off-by: Elmer Miroslav Mosher Golovin <[email protected]>
  • Loading branch information
mishamosher committed Apr 25, 2023
1 parent ad36f50 commit 1a9ddd7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
8 changes: 8 additions & 0 deletions recording/server.conf.in
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,11 @@

# The extension of the file for audio and video recordings.
#extensionvideo = .webm

[recording]
# Browser to use for recordings. Please note that the "chrome" value does not
# refer to the web browser, but to the Selenium WebDriver. In practice, "chrome"
# will use Google Chrome, or Chromium if Google Chrome is not installed.
# Allowed values: firefox, chrome
# Defaults to firefox
# browser = firefox
5 changes: 4 additions & 1 deletion recording/src/nextcloud/talk/recording/Service.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#
# @copyright Copyright (c) 2023, Daniel Calviño Sánchez ([email protected])
# @copyright Copyright (c) 2023, Elmer Miroslav Mosher Golovin ([email protected])
#
# @license GNU AGPL version 3 or any later version
#
Expand Down Expand Up @@ -188,8 +189,10 @@ def start(self, actorType, actorId):
env = self._display.env()
env['PULSE_SINK'] = audioSinkIndex

browser = config.getBrowserForRecording()

self._logger.debug("Starting participant")
self._participant = Participant('firefox', self.backend, width, height, env, self._logger)
self._participant = Participant(browser, self.backend, width, height, env, self._logger)

self._logger.debug("Joining call")
self._participant.joinCall(self.token)
Expand Down

0 comments on commit 1a9ddd7

Please sign in to comment.