fixup! feat(LinkShareSettings): respect force public conversations pa…

…ssword config in set public type switch (conversation already created)
nextcloud · Dec 6, 2024 · 445a876 · 445a876
1 parent 36f5ab2
commit 445a876
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/services/conversationsService.js b/src/services/conversationsService.js
@@ -227,7 +227,7 @@ const setNotificationCalls = async function(token, level) {
  * @param {string} token The token of the conversation to be removed from favorites
  * @param {string} password The password to set for the conversation (optional, only if force password is enabled)
  */
-const makeConversationPublic = async function(token, password = '') {
+const makeConversationPublic = async function(token, password) {
 	const data = (hasTalkFeature(token, 'conversation-creation-password') && password)
 		? { password }
 		: undefined

diff --git a/src/store/conversationsStore.spec.js b/src/store/conversationsStore.spec.js
@@ -648,7 +648,7 @@ describe('conversationsStore', () => {
 				allowGuests: true,
 			})
 
-			expect(makeConversationPublic).toHaveBeenCalledWith(testToken)
+			expect(makeConversationPublic).toHaveBeenCalledWith(testToken, undefined)
 
 			const changedConversation = store.getters.conversation(testToken)
 			expect(changedConversation.type).toEqual(CONVERSATION.TYPE.PUBLIC)