-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(MediaSettings): Add audio test #11624
Conversation
I used something like bing sound for audio output testing. However, I can also add voice recording as a test for the mic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind adding a new sound, just feeling that default call waiting fits better here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @DorraJaouad
I would left-align this new button so that the speaker icon is vertically aligned with the mic and camera icons, and change the test to "Test speakers".
Also, given that we're adding more elements, could we move the "always show dialog" setting in the 3-dot menu next to the button as an action checkbox component?
Exactly that was the idea, it would basically allow you to test both, mic and speaker |
Right, but some users want just to test speaker and they don't want to randomly say some words XD . That's why I chose the first option. So add both or only voice recorder ? |
I leave that to design cc @marcoambrosini As for what to play, any issue with playing an already existing file (less files, more caching, less license issues, etc) |
@DorraJaouad @nickvergessen would it be possible to have a third entry with speaker selection similar to Jitsi? Or at least showing which is the current speaker? |
sinkId can show the audio output being used but read only and it is not supported on Safari. Otherwise, selectAudioOutput allows user to select audio ouput device but it is only supported on Firefox. |
navigator.mediaDevices.enumerateDevices().then((devices) => {
devices.forEach((device) => {
console.log(`${device.kind}: ${device.label} id = ${device.deviceId}`);
});
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this will suffice for now. I'll open an issue for improvements once this is in
Signed-off-by: Maksim Sukharev <[email protected]>
cdfc1b2
to
cb89e14
Compare
Signed-off-by: DorraJaouad <[email protected]> Signed-off-by: Maksim Sukharev <[email protected]>
cb89e14
to
c699ada
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Screencast :
audio-test.webm
🚧 Tasks
🏁 Checklist