Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Participants): mark federated users in MessagesList and ParticipantList #11771

Merged
merged 5 commits into from
Mar 12, 2024
Merged

feat(Participants): mark federated users in MessagesList and ParticipantList #11771

merged 5 commits into from
Mar 12, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 11, 2024 •
edited
Loading

☑️ Resolves

  • Feat: mark federated users in MessagesList and ParticipantList:
    • web icon at the user_status place, where applicable
    • server address in parenthesis next to user name
  • Fix regression from feat(federation): Support mentioning federated users #11664 :
    • don't replace id with mentionId if not available
  • Follow-up to user proxy avatars:
    • use NcAvatarWrapper in ReactionsList

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

☀️ Light theme 🌑 Dark Theme
image image
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💞 Next Beta (29) milestone Mar 11, 2024
@Antreesy Antreesy self-assigned this Mar 11, 2024
@Antreesy Antreesy force-pushed the fix/noid/mark-federated-users branch from 32f6eb7 to bcbffe1 Compare March 11, 2024 15:39
@Antreesy Antreesy force-pushed the fix/noid/mark-federated-users branch from 9e4b4d4 to 135cb20 Compare March 11, 2024 17:07
DorraJaouad
DorraJaouad approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.
Visualizations look good too 👍🏻

@Antreesy Antreesy merged commit 9c5a927 into main Mar 12, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/mark-federated-users branch March 12, 2024 11:33
@nickvergessen nickvergessen mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels
3. to review feature: federation 🌐 feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-beta.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad