Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PublicShareSidebar): fix prop reactivity #12133

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(PublicShareSidebar): fix prop reactivity #12133

merged 1 commit into from
Apr 17, 2024

Conversation

DorraJaouad
Copy link
Contributor

☑️ Resolves

Vue was not tracking the object changes in computed ( though in prop, it was changed), which means it's not reactive.

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added the feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents label Apr 17, 2024
@DorraJaouad DorraJaouad added this to the 💙 Next Major (30) milestone Apr 17, 2024
@DorraJaouad DorraJaouad requested a review from ShGKme April 17, 2024 07:59
@DorraJaouad DorraJaouad self-assigned this Apr 17, 2024
@DorraJaouad DorraJaouad enabled auto-merge April 17, 2024 08:07
@DorraJaouad DorraJaouad merged commit d7ea866 into main Apr 17, 2024
45 checks passed
@DorraJaouad DorraJaouad deleted the fix/12132/public-share-sidebar branch April 17, 2024 08:20
@nickvergessen
Copy link
Member

Fixes the button, but the wrong color of the icon is still a thing 🙈
The file name however is also wrong (using the same variable, but directly instead of via a button).

@nickvergessen
Copy link
Member

/backport to stable29

@backportbot backportbot bot mentioned this pull request Apr 17, 2024
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 17, 2024
Closed
2 tasks
@DorraJaouad
Copy link
Contributor Author

/backport to stable28

@DorraJaouad
Copy link
Contributor Author

/backport to stable27

@backportbot backportbot bot mentioned this pull request Jun 11, 2024
Merged
@backportbot backportbot bot mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v20.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

polishing of sidebar in public view
3 participants
@DorraJaouad @nickvergessen @ShGKme