feat(meetings): Add endpoint to get writable calendars and the defaul… #13964
+430
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t calendar Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
enhancement
feature: api 🛠️
… default calendar
|
Noticed that default calendar has a color 'null'. Is it also the case for you, and is it on our side? In calendar app i see it as purple, but maybe that's a fallback |
Color can be null, yes (as defined on the API). In that case you should use the primary color. |
miaulalala
requested changes
Dec 11, 2024
Comment on lines
+157
to
+173
| protected function getSchedulingCalendarFromPropertiesTable(string $userId) { | ||
| $propertyPath = 'principals/users/' . $userId; | ||
| $propertyName = '{urn:ietf:params:xml:ns:caldav}schedule-default-calendar-URL'; | ||
|
|
||
| $query = $this->db->getQueryBuilder(); | ||
| $query->select('propertyvalue') | ||
| ->from('properties') | ||
| ->where($query->expr()->eq('userid', $query->createNamedParameter($userId))) | ||
| ->andWhere($query->expr()->eq('propertypath', $query->createNamedParameter($propertyPath))) | ||
| ->andWhere($query->expr()->eq('propertyname', $query->createNamedParameter($propertyName))) | ||
| ->setMaxResults(1); | ||
|
|
||
| $result = $query->executeQuery(); | ||
| $property = $result->fetchOne(); | ||
| $result->closeCursor(); | ||
|
|
||
| return $property; |
There was a problem hiding this comment.
You should go through the DAV app to get the default calendar URI, or you can use the user config:
$uri = $this->appConfig->getUserValue($userId, 'dav', 'defaultCalendar', CalDavBackend::PERSONAL_CALENDAR_URI);
There was a problem hiding this comment.
right, should use that preference,
but going through the dav app is to risky as it's all private api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t calendar
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
schedule-meetingwill be added once all APIs are implemented🏁 Checklist
docs/has been updated or is not required