fix(backends): Check times of the backend servers #14012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
feature: settings ⚙️
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
SystemKeeper
approved these changes
Dec 18, 2024
fancycode
reviewed
Dec 18, 2024
There was a problem hiding this comment.
+1 for some leeway.
The signaling server allows up to one minute time difference when validating tokens:
https://github.com/strukturag/nextcloud-spreed-signaling/blob/0a04ea290969cfe1ebc3ef3aaeeae1bdc49ea552/hub.go#L114-L115
|
then we use 45 to be on the safe side, so there are still ~15s in worst case between getting the token and sending the request? |
👍 sounds good |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/check-server-times
branch
from
59819b8 to
ef632ef
Compare
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required