feat: Add search message tab to the right sidebar

[JungleDruid]

☑️ Resolves

• Fix Search inside Talk App doesn't include talk messages #11130

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

1.mp4

🚧 Tasks

• ...

🏁 Checklist

• 🌏 Tested with different browsers / clients:
  • Chromium (Chrome / Edge / Opera / Brave)
  • Firefox
  • Safari
  • Talk Desktop
  • Not risky to browser differences / client
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

[Antreesy]

Hi @JungleDruid, thanks for the contribution! That is a decent work, tried to play with it a bit 🚀

I assume it's meant to be used in Desktop client? cc @ShGKme for opinion

Couple of things to consider:
API-wise:

• search is done via provider, but it originates from Talk backend anyway, I wonder if exposing it as Talk endpoint would affect performance to the better (not relevant for this PR, just a follow-up);
  Design-wise:
• there were some discussions in past, that abusing right sidebar tabs is better to avoid (you have now 3 tabs on screenshots, during the call it will be 4 tabs, if breakout rooms are configured - 5!) I personally found the way Discord does it appropriate - replacing participants list with search results:

search	users

• Filters could be wrapped in NcPopover (with some styling), similar way it's used in web Unified Search:

Frontend-wise:

• We're now aiming to update old and write new Vue components with following structure and would greatly appreciate that from contributors:

<script setup lang="ts">
<template>
<style>

• In addition to that, adding input/output typings in src/types/index.ts would be also nice, so component is aware, what to expect from this endpoint. (could be later improved, if endpoint will be exposed)
• There is currently an issue with loading old message results (it pulls all messages until the end of convesation, which might freeze browser/client). But your PR reaches them correctly, so could be fixed separately, I'll try to take a look in it.

We might discuss it internally with the engineering and design teams only after holidays, so please don't rush with changes =) It is also possible to reach us via 💬 Talk team public 👥 channel, don't hesitate to ask there

[JungleDruid]

Hey @Antreesy,

Thanks for the kind words and suggestions!

I originally tried adding the feature to the conversation search in the left sidebar, but it felt too crowded with all the different results. Adding filter options there didn’t seem to fit well either, so I decided to create a new tab instead. That said, I see your point, there are quite a few tabs now! 😅 I’ll explore the idea of replacing the right sidebar when search is activated (similar to Discord), or perhaps replacing the left sidebar (like Telegram Desktop).

For the filter styles, I did consider using NcPopover, but I thought keeping the filters visible might be more user-friendly since it wouldn’t disappear or block the view during searches. The design was inspired by VS Code:

I wasn’t aware of the Vue component structure shift, thanks for pointing that out! I’ll start using the new structure from now on.

Thanks again for taking the time to review and share your thoughts, and happy holidays! 🎄

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)