-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): allow to select meeting attendees #14097
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
if (this.actorType === ATTENDEE.ACTOR_TYPE.EMAILS) { | ||
return this.participant.invitedActorId | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking that current user is a moderator makes it safer to use in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be a task of this component IMO, but I'll put it on board
Merging for today |
Signed-off-by: Maksim Sukharev <[email protected]>
1bed6ae
to
64931f8
Compare
Awesome! Great that we will be able to add attendees! Some points for feedback:
Regarding the attendees modal, 3 points for feedback:
Super cool work! :) |
Well but it does not invite all participants… federated users don't work, normal guests don't work, … |
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist