Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): allow to select meeting attendees #14097

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Follow-up

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

image image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Jan 10, 2025
@Antreesy Antreesy self-assigned this Jan 10, 2025
@Antreesy Antreesy changed the title fix(participants): allow to search for email guests feat(calendar): allow to select meeting attendees Jan 10, 2025
Comment on lines +122 to +124
if (this.actorType === ATTENDEE.ACTOR_TYPE.EMAILS) {
return this.participant.invitedActorId
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking that current user is a moderator makes it safer to use in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be a task of this component IMO, but I'll put it on board

@nickvergessen
Copy link
Member

Merging for today

@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting-attendees branch from 1bed6ae to 64931f8 Compare January 10, 2025 13:41
@Antreesy Antreesy merged commit 5408fe2 into main Jan 10, 2025
50 checks passed
@Antreesy Antreesy deleted the feat/6292/frontend-schedule-meeting-attendees branch January 10, 2025 13:44
@nimishavijay
Copy link
Member

nimishavijay commented Jan 10, 2025

Awesome! Great that we will be able to add attendees! Some points for feedback:

  • Distinguish the entire section by adding a heading "Attendees"
  • Instead of a toggle, use a checkmark. Toggles are usually used for more "technical" settings IMO
  • "Select attendees" button can be tertiary and add a person-add icon
  • "Select attendees" button and summary can be in different rows to prevent the button position shifting slightly when the number changes
  • Wording adjustments:
    • It took a second for me to understand Invite all users and email guests --> Invite all participants in the conversation and email guests
    • Select attendees --> Add attendees
    • Sending 14 invitations --> [👩 Alice Doe], [👨 Sam Smith] and 12 more guests will receive invites (ideal) or 14 guests will receive invites
    • For errors, don't prefix with "Error: ", we can just say what's wrong like "Invalid start time set" :)

image

Regarding the attendees modal, 3 points for feedback:

  • Select attendees --> Add attendees
  • If possible, show the selected attendees up top like when you create a new group conversation in Talk (in fact, the whole modal can just be replicated)
  • Add a ✔️ Done or ✔️ Save button at the end to prevent confusion about whether or not the attendees are added
    image

Super cool work! :)

@nickvergessen
Copy link
Member

It took a second for me to understand Invite all users and email guests --> Invite all participants in the conversation and email guests

Well but it does not invite all participants… federated users don't work, normal guests don't work, …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants