Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RoomFormatter): expose lastReadMessage if user is in the lobby #14515

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix(RoomFormatter): expose lastReadMessage if user is in the lobby #14515

merged 2 commits into from
Feb 28, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 27, 2025 •
edited
Loading

☑️ Resolves

  • Ref Chat does not show messages list after lobby disabled #14368
  • When moderator disables lobby, user receive updated common room properties via HPB signaling message. If lobbyState changes to 0, that unlocks chat messaging. But user-level parameters, like lastReadMessage === 0, and some other are not updated, thus blocking getting the message context

🖌️ API Checklist

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added 3. to review bug feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby labels Feb 27, 2025
@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 27, 2025
@Antreesy Antreesy self-assigned this Feb 27, 2025
@nickvergessen nickvergessen force-pushed the fix/14368/should-refresh-conversation branch from 96e059b to 64e2da9 Compare February 28, 2025 09:51
@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen
Copy link
Member

/backport to stable31

@nickvergessen nickvergessen merged commit faadeba into main Feb 28, 2025
77 checks passed
@nickvergessen nickvergessen deleted the fix/14368/should-refresh-conversation branch February 28, 2025 10:02
This was referenced Feb 28, 2025
Merged
Merged
@Antreesy Antreesy changed the title fix(LeftSidebar): fetch room if user was in the lobby fix(RoomFormatter): expose lastReadMessage if user is in the lobby Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @DorraJaouad