Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
avoid error when declining recording consent
Browse files Browse the repository at this point in the history
When declining recording consent, 404 might be returned when leaving the call (because the call was not joined before).
It might not be the best option to handle this via onError, but for the moment (18.0.0 release) it's the most robust/lowest-risk solution without to change some state handling to check if the call was joined).
finish was added which makes sense anyway, but for declining recording consent the error snackbar was removed.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi committed Dec 6, 2023
1 parent 2b146b2 commit 4bfe3a4
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -2049,7 +2049,7 @@ class CallActivity : CallBaseActivity() {
}

override fun onNext(genericOverall: GenericOverall) {
if (!switchToRoomToken.isEmpty()) {
if (switchToRoomToken.isNotEmpty()) {
val intent = Intent(context, ChatActivity::class.java)
intent.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TOP)
val bundle = Bundle()
@@ -2070,8 +2070,8 @@ class CallActivity : CallBaseActivity() {
}

override fun onError(e: Throwable) {
Snackbar.make(binding!!.root, R.string.nc_common_error_sorry, Snackbar.LENGTH_LONG).show()
Log.e(TAG, "Error while leaving the call", e)
Log.w(TAG, "Something went wrong when leaving the call", e)
finish()
}

override fun onComplete() {

0 comments on commit 4bfe3a4

Please sign in to comment.