fix(detekt): shorten test method by extracting conversation object cr…

…eation Signed-off-by: Andy Scherzinger <[email protected]>
nextcloud · Dec 2, 2024 · 5011649 · 5011649
1 parent 720fdda
commit 5011649
Showing 1 changed file with 28 additions and 24 deletions.
diff --git a/app/src/test/java/com/nextcloud/talk/utils/ParticipantPermissionsTest.kt b/app/src/test/java/com/nextcloud/talk/utils/ParticipantPermissionsTest.kt
@@ -21,7 +21,34 @@ class ParticipantPermissionsTest : TestCase() {
     @Test
     fun test_areFlagsSet() {
         val spreedCapability = SpreedCapability()
-        val conversation = Conversation(
+        val conversation = createConversation()
+
+        conversation.permissions = ParticipantPermissions.PUBLISH_SCREEN or
+            ParticipantPermissions.JOIN_CALL or
+            ParticipantPermissions.DEFAULT
+
+        val user = User()
+        user.id = 1
+
+        val attendeePermissions =
+            ParticipantPermissions(
+                spreedCapability,
+                ConversationModel.mapToConversationModel(conversation, user)
+            )
+
+        assert(attendeePermissions.canPublishScreen)
+        assert(attendeePermissions.canJoinCall)
+        assert(attendeePermissions.isDefault)
+
+        assertFalse(attendeePermissions.isCustom)
+        assertFalse(attendeePermissions.canStartCall())
+        assertFalse(attendeePermissions.canIgnoreLobby())
+        assertTrue(attendeePermissions.canPublishAudio())
+        assertTrue(attendeePermissions.canPublishVideo())
+    }
+
+    private fun createConversation(): Conversation {
+        return Conversation(
             token = "test",
             name = "test",
             displayName = "test",
@@ -67,28 +94,5 @@ class ParticipantPermissionsTest : TestCase() {
             remoteServer = "",
             remoteToken = ""
         )
-
-        conversation.permissions = ParticipantPermissions.PUBLISH_SCREEN or
-            ParticipantPermissions.JOIN_CALL or
-            ParticipantPermissions.DEFAULT
-
-        val user = User()
-        user.id = 1
-
-        val attendeePermissions =
-            ParticipantPermissions(
-                spreedCapability,
-                ConversationModel.mapToConversationModel(conversation, user)
-            )
-
-        assert(attendeePermissions.canPublishScreen)
-        assert(attendeePermissions.canJoinCall)
-        assert(attendeePermissions.isDefault)
-
-        assertFalse(attendeePermissions.isCustom)
-        assertFalse(attendeePermissions.canStartCall())
-        assertFalse(attendeePermissions.canIgnoreLobby())
-        assertTrue(attendeePermissions.canPublishAudio())
-        assertTrue(attendeePermissions.canPublishVideo())
     }
 }