Skip to content

Commit

Permalink
fix to provide all call emojis
Browse files Browse the repository at this point in the history
As the number of provided emojis grew, there was a bug that only one emoji was shown.

Putting all 12 emojis would have been too close, so it's implemented to scroll them horizontally

Signed-off-by: Marcel Hibbe <[email protected]>
  • Loading branch information
mahibi committed Nov 14, 2024
1 parent 3908d0c commit 59ee0b0
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,8 @@ class MoreCallActionsDialog(private val callActivity: CallActivity) : BottomShee
capabilities?.spreedCapability?.config!!["call"]!!["supported-reactions"] as ArrayList<*>

val param = LinearLayout.LayoutParams(
LinearLayout.LayoutParams.MATCH_PARENT,
LinearLayout.LayoutParams.MATCH_PARENT,
1.0f
EMOJI_WIDTH,
LinearLayout.LayoutParams.MATCH_PARENT
)

availableReactions.forEach {
Expand Down Expand Up @@ -185,5 +184,6 @@ class MoreCallActionsDialog(private val callActivity: CallActivity) : BottomShee
companion object {
private const val TAG = "MoreCallActionsDialog"
private const val TEXT_SIZE = 20f
private const val EMOJI_WIDTH = 80
}
}
26 changes: 17 additions & 9 deletions app/src/main/res/layout/dialog_more_call_actions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,26 @@
android:layout_width="match_parent"
android:layout_height="wrap_content" />

<LinearLayout
android:id="@+id/call_emoji_bar"
<HorizontalScrollView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_height="match_parent"
android:fadingEdgeLength="30dp"
android:layout_marginStart="@dimen/standard_margin"
android:layout_marginTop="@dimen/standard_half_margin"
android:layout_marginEnd="@dimen/standard_margin"
android:layout_marginBottom="@dimen/standard_half_margin"
android:gravity="center_vertical"
android:orientation="horizontal"
android:weightSum="10">
</LinearLayout>
android:requiresFadingEdge="horizontal"
android:scrollbars="none">

<LinearLayout
android:id="@+id/call_emoji_bar"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/standard_half_margin"
android:layout_marginBottom="@dimen/standard_half_margin"
android:gravity="center_vertical"
android:orientation="horizontal">
</LinearLayout>

</HorizontalScrollView>

<TextView
android:id="@+id/advanced_call_options_title"
Expand Down

0 comments on commit 59ee0b0

Please sign in to comment.