Found the bug, partial fix

Signed-off-by: rapterjet2004 <[email protected]>
nextcloud · Nov 20, 2023 · 7860f2d · 7860f2d
1 parent e659456
commit 7860f2d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt b/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt
@@ -2183,16 +2183,16 @@ class ChatActivity :
         recorder?.apply {
             try {
                 Log.d(TAG, "recording stopped with $voiceRecordDuration")
-                if (voiceRecordDuration > MINIMUM_VOICE_RECORD_TO_STOP) {
+                try {
                     stop()
+                    isVoiceRecordingInProgress = false
+                    Log.d(TAG, "stopped recorder. isVoiceRecordingInProgress = false")
+                } catch (e: java.lang.RuntimeException) {
+                    Log.e(TAG, "error while stopping recorder!" + e)
                 }
                 release()
-                isVoiceRecordingInProgress = false
-                Log.d(TAG, "stopped recorder. isVoiceRecordingInProgress = false")
             } catch (e: java.lang.IllegalStateException) {
-                error("error while stopping recorder!" + e)
-            } catch (e: java.lang.RuntimeException) {
-                error("error while stopping recorder!" + e)
+                Log.e(TAG, "error while stopping recorder!" + e)
             }
 
             VibrationUtils.vibrateShort(context)

diff --git a/app/src/main/java/com/nextcloud/talk/utils/AudioUtils.kt b/app/src/main/java/com/nextcloud/talk/utils/AudioUtils.kt
@@ -78,7 +78,7 @@ object AudioUtils : DefaultLifecycleObserver {
             val path = file.path
             val mediaExtractor = MediaExtractor()
             mediaExtractor.setDataSource(path)
-
+            // TODO this function assumes that the file is not null. Fix it.
             // Basically just boilerplate to set up meta data for the audio file
             val mediaFormat = mediaExtractor.getTrackFormat(0)
             // Frame rate is required for encoders, optional for decoders. So we set it to null here.