Skip to content

Commit

Permalink
add disposable
Browse files Browse the repository at this point in the history
however i was not able to see onDestroy being executed.

anyway, disposables won't be necessary when coroutine is used.

also: remove a useless outdated log line

Signed-off-by: Marcel Hibbe <[email protected]>
  • Loading branch information
mahibi committed Nov 14, 2024
1 parent 8dd1b88 commit acd9648
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2448,7 +2448,7 @@ class ChatActivity :
currentlyPlayedVoiceMessage?.let { stopMediaPlayer(it) } // FIXME, mediaplayer can sometimes be null here

adapter = null
Log.d(TAG, "inConversation was set to false!")
disposables.dispose()
}

private fun joinRoomWithPassword() {
Expand Down Expand Up @@ -2513,7 +2513,7 @@ class ChatActivity :
?.observeOn(AndroidSchedulers.mainThread())
?.subscribe(object : Observer<SignalingSettingsOverall> {
override fun onSubscribe(d: Disposable) {
// unused atm
disposables.add(d)
}

override fun onNext(signalingSettingsOverall: SignalingSettingsOverall) {
Expand Down

0 comments on commit acd9648

Please sign in to comment.