Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emoji picker sometimes opens in full screen height #1914

Closed
Tracked by #1895
mahibi opened this issue Apr 9, 2022 · 0 comments · Fixed by #1942
Closed
Tracked by #1895

emoji picker sometimes opens in full screen height #1914

mahibi opened this issue Apr 9, 2022 · 0 comments · Fixed by #1942
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 🗨️ chat
Milestone
14.0.0

Comments

@mahibi
Copy link
Collaborator

mahibi commented Apr 9, 2022 •
edited
Loading

Steps to reproduce

  1. react to message with custom emoji (-> open emoji dialog by "..." button)

Expected behaviour

emoji popup always open with the same size that the keyboard would have

Actual behaviour

this behaviour was fixed for other occurences of the emoji picker inside the talk app. It might be more difficult to find a workaround this time because it's now used inside a BottomDialog?!

related:
#1668 (comment)

talk app version: 14.1.0 Alpha 1
@mahibi mahibi added bug Something isn't working 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) feature: 🗨️ chat labels Apr 9, 2022
@mahibi mahibi added this to the 14.0.1 milestone Apr 9, 2022
@mahibi mahibi mentioned this issue Apr 9, 2022
Merged
17 tasks
@mahibi mahibi modified the milestones: 14.0.1, 14.0.0 Apr 19, 2022
mahibi added a commit that referenced this issue Apr 22, 2022
@mahibi
add workaround to avoid emoji picker to take the full screen height
2495c25 
The toggleEmojiPopup method is a hacky workaround to avoid bug #1914
As the bug happens only for the very first time when the popup is opened,
it is closed after some milliseconds and opened again.

200 milliseconds seems to be a good value to initialize the popup correctly with the desired size

downside: there is even some flickering when opening the "more emojis" window

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi mentioned this issue Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) bug Something isn't working feature: 🗨️ chat
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

add workaround to avoid emoji picker to take the full screen height nextcloud/talk-android
1 participant
@mahibi