add workaround to avoid emoji picker to take the full screen height #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toggleEmojiPopup method is a hacky workaround to avoid bug #1914 As the bug happens only for the very first time when the popup is opened, it is closed after some milliseconds and opened again. 200 milliseconds seems to be a good value to initialize the popup correctly with the desired size downside: there is even some flickering when opening the "more emojis" window Signed-off-by: Marcel Hibbe <[email protected]>
AndyScherzinger
approved these changes
Apr 23, 2022
Signed-off-by: Andy Scherzinger <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1942-talk.apk |
Lint
SpotBugs (new)
SpotBugs (master)
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first try to fix #1914
The toggleEmojiPopup method is a hacky workaround to avoid bug #1914
As the bug happens only for the very first time when the popup is opened,
it is closed after some milliseconds and opened again.
200 milliseconds seems to be a good value to initialize the popup correctly with the desired size
downside: there is even some flickering when opening the "more emojis" window
Signed-off-by: Marcel Hibbe [email protected]