TakePhotoActivity: Use full field of view #2016
Conversation
Some devices have a digital video stabilization mode that uses a smaller field of view within the full set of sensor data, and moves the selected subset around like on rubber bands in order to reduce shaking in video captures. Most devices default this mode to OFF, but some, like Pixel 6 Pro, default this mode to ON, which causes image and video captures to have a reduced field of view. This change will have no effect on most devices, but will increase field of view to full on those devices that do not by default. Reference: https://issuetracker.google.com/issues/230013960 Signed-off-by: Adam Serbinski <[email protected]>
|
so i guess merge without being able to test.. as you implemented the camera i requested a review @AndyScherzinger |
1 similar comment
|
so i guess merge without being able to test.. as you implemented the camera i requested a review @AndyScherzinger |
|
@ASerbinski btw we added you to the nextcloud org back then, see https://github.com/orgs/nextcloud/people?query=ASerbinski so you can actually push to this repo directly to a branch, so you don't have to maintain a fork of the repo. makes things easier, just wanted to let you know in case you forgot :) |
|
Code-wise looks good to me 👍 So merging! Thanks again for this contribution @ASerbinski all your work around the camera implementation is highly appreciated - makes my day 🙏 |
|
thank you @ASerbinski 👍 👍 |
|
I'm happy to contribute any time I have something to offer. @AndyScherzinger I actually forgot about that. I'll keep it in mind for next time. I plan to try to add a toggle for EIS on video calls along the same lines as I contributed to grapheneos camera; GrapheneOS/Camera@4eafcbb |
|
@ASerbinski that is so awesome! 🎉 |
Some devices have a digital video stabilization mode that uses a smaller field of view within the full set of sensor data, and moves
the selected subset around like on rubber bands in order to reduce shaking in video captures. Most devices default this mode to OFF, but some, like Pixel 6 Pro, default this mode to ON, which causes image and video captures to have a reduced field of view.
This change will have no effect on most devices, but will increase field of view to full on those devices that do not by default.
Reference: https://issuetracker.google.com/issues/230013960
Signed-off-by: Adam Serbinski [email protected]