Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override emoji search field hint text to be translatable #2119

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

AndyScherzinger
Copy link
Member

Resolves #2110

Signed-off-by: Andy Scherzinger [email protected]

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jun 2, 2022
@AndyScherzinger AndyScherzinger added this to the 14.1.0 milestone Jun 2, 2022
@AndyScherzinger AndyScherzinger marked this pull request as ready for review June 2, 2022 08:10
@AndyScherzinger AndyScherzinger force-pushed the bugfix/2110/translatableLibStrings branch from 7a19fdd to 3c2864f Compare June 2, 2022 08:11
@AndyScherzinger AndyScherzinger force-pushed the bugfix/2110/translatableLibStrings branch from 3c2864f to cedd929 Compare June 2, 2022 08:19
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2119-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi self-requested a review June 2, 2022 08:55
@mahibi
Copy link
Collaborator

mahibi commented Jun 2, 2022

tested and works.

but when testing this i saw that #2104 might sometimes cause that the emojis that are shown in the menu are still visible but are overlayed. created #2120

@AndyScherzinger AndyScherzinger merged commit ebef2f8 into master Jun 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2110/translatableLibStrings branch June 2, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[14.1.0 Alpha 07] i18n: Translate "Search" for Emoji
2 participants