Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/3298/detect talking and send data channel message stable17.1 #3301

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Backport/3298/detect talking and send data channel message stable17.1 #3301

merged 2 commits into from
Sep 6, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 6, 2023 •
edited
Loading

backport of #3298

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added this to the 17.1.0 milestone Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Codacy

Lint

TypemasterPR
Warnings9393
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3301-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 0f5fed1 into stable-17.1 Sep 6, 2023
12 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/3298/detectTalkingAndSendDataChannelMessage_stable17.1 branch September 6, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mahibi