Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show accept call button in chat #3307

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Show accept call button in chat #3307

merged 1 commit into from
Oct 2, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 8, 2023 •
edited
Loading

fixes #3260

Current UI

Dark Light Guest
image image image

Functionality

show-accept-button-1.webm
  • Both join audio and video buttons
  • Gets deleted if call ends, persists despite state or adapter changes
  • Themed

TODO

  • Complete Functionality
    • Get it working for guests
    • Get it working for users
  • Finish Implementing the mention chip
  • detekt 😠
  • review
  • deal with git commit signatures

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Sep 8, 2023
@rapterjet2004 rapterjet2004 force-pushed the show-accept-button branch 4 times, most recently from af340c2 to a92d533 Compare September 19, 2023 12:09
@rapterjet2004 rapterjet2004 marked this pull request as ready for review September 19, 2023 15:44
@rapterjet2004 rapterjet2004 force-pushed the show-accept-button branch 2 times, most recently from 4e6cdb2 to f719978 Compare September 22, 2023 12:15
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 22, 2023
@rapterjet2004 rapterjet2004 requested review from mahibi and AndyScherzinger and removed request for mahibi September 22, 2023 12:52
@AndyScherzinger
Copy link
Member

  • detekt 😠

You can do a local CLI call to .\gradlew detekt as well as .\gradlew ktlintCheck before pushing your code to ensure the check succeed on Github. And in case you want it integrated with git just call .\gradlew installGitHooks.

All commands are to be executed on your checked-out root of the project.

@rapterjet2004 rapterjet2004 force-pushed the show-accept-button branch 2 times, most recently from e67ceab to 8982623 Compare September 27, 2023 15:16
@mahibi mahibi added this to the 17.2.0 milestone Sep 27, 2023
@rapterjet2004
Show Accept Call Button in Chat
6db2f34 
- added call_started_message.xml
- added CallStartedViewHolder.kt
- added CallStartedMessageInterface.kt
- Both join audio and join video buttons
- Gets destroyed if call ends, persists despite state changes

Signed-off-by: Julius Linus <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3307-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Codacy

Lint

TypemasterPR
Warnings9191
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@AndyScherzinger AndyScherzinger merged commit 50c51c1 into master Oct 2, 2023
15 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the show-accept-button branch October 2, 2023 18:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews enhancement New feature or request feature: ☎️ call feature: 🗨️ chat feedback-requested
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.

show accept call button in chat
3 participants
@rapterjet2004 @AndyScherzinger @mahibi