Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with continuous voice recording #3321

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 17, 2023

fixed bug with audio messages not sending after pausing in continuous voice recording mode. I must have forgotten to remove those two if statements, when fixing a previous bug.

voice-recording-bug-fix.webm

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added bug Something isn't working 3. to review Waiting for reviews labels Sep 17, 2023
@rapterjet2004 rapterjet2004 self-assigned this Sep 17, 2023
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3321-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9393
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@AndyScherzinger AndyScherzinger merged commit 3bb3b28 into master Sep 18, 2023
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the voice-recording-glitch-on-pause branch September 18, 2023 19:48
@mahibi mahibi added this to the 17.2.0 milestone Oct 17, 2023
@mahibi
Copy link
Collaborator

mahibi commented Oct 17, 2023

/backport to stable-17.1

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants