Replaced ListView with RecyclerView

[Smarshal21]

🖼️ Screenshots

Portrait

Landscape

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[Smarshal21]

@AndyScherzinger PTAL and do tell me if LiveData should be implemented.

[AndyScherzinger]

@AndyScherzinger PTAL and do tell me if LiveData should be implemented.

Looks good to me. LiveData would be nice if you have the time and motivation for it. I'll take care of merging this PR, so LiveData can/should then go into a separate PR, to keep PRs at a small size, to make it easier for reviewers 👍

Nice work! 🚀

[Smarshal21]

@AndyScherzinger PTAL and do tell me if LiveData should be implemented.

Looks good to me. LiveData would be nice if you have the time and motivation for it. I'll take care of merging this PR, so LiveData can/should then go into a separate PR, to keep PRs at a small size, to make it easier for reviewers 👍

Nice work! 🚀

Sure will do

[rapterjet2004]

Looks good! The adapter works great but the OnClickListener for the GeocodingAdapter items don't seem to be working on this branch. Upon clicking the item, it should take you back to the LocationPickerActivity with the new location.

Master

replaced-listView-branch-Master.webm

RecyclerView

replace-listview-branch-RecyclerView.webm

[rapterjet2004]

I figured out the bug, the adapter is not being updated after the ItemClicker is set up. Just implement the changes I suggested and it should work. Overall good work!

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	92	91
Errors	0	0

SpotBugs

Category	Base	New
Correctness	9	9
Dodgy code	123	123
Internationalization	5	5
Malicious code vulnerability	3	3
Performance	8	8
Security	2	2
Total	150	150

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3322-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[AndyScherzinger]

Nice catch @rapterjet2004 👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!